Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Stop reverting on precompiles #803

Merged

Conversation

ClementWalter
Copy link
Member

Time spent on this PR: 0.2

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Some Cairo VM errors in precompiles

What is the new behavior?

Returns a reverted context as in other errors.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (a396881) 71.24% compared to head (bb995fd) 71.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   71.24%   71.63%   +0.39%     
==========================================
  Files          45       45              
  Lines        5933     6068     +135     
==========================================
+ Hits         4227     4347     +120     
- Misses       1706     1721      +15     
Files Coverage Δ
src/kakarot/precompiles/blake2f.cairo 58.65% <100.00%> (+0.43%) ⬆️
src/kakarot/precompiles/datacopy.cairo 100.00% <100.00%> (ø)
src/kakarot/precompiles/ec_recover.cairo 100.00% <100.00%> (ø)
src/kakarot/precompiles/ecadd.cairo 100.00% <100.00%> (ø)
src/kakarot/precompiles/ecmul.cairo 100.00% <100.00%> (ø)
src/kakarot/precompiles/modexp.cairo 96.42% <100.00%> (ø)
src/kakarot/precompiles/precompiles.cairo 91.01% <100.00%> (+31.48%) ⬆️
src/kakarot/precompiles/ripemd160.cairo 64.78% <100.00%> (ø)
src/kakarot/precompiles/sha256.cairo 92.65% <100.00%> (+6.53%) ⬆️
src/kakarot/errors.cairo 25.39% <10.90%> (+21.76%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion

src/kakarot/errors.cairo Show resolved Hide resolved
src/kakarot/errors.cairo Show resolved Hide resolved
@ClementWalter ClementWalter merged commit 4c2ef03 into kkrt-labs:main Nov 8, 2023
6 of 7 checks passed
@ClementWalter ClementWalter deleted the cw/stop-reverting-on-precompiles branch November 8, 2023 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants