This repository has been archived by the owner on Jan 9, 2025. It is now read-only.
Put balance in Account instead of State #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementWalter
force-pushed
the
cw/add-balance-in-account
branch
from
191236f to
4a74b87
Compare
Eikix
reviewed
Nov 21, 2023
ClementWalter
force-pushed
the
cw/add-balance-in-account
branch
2 times, most recently
from
7780b4d to
d407679
Compare
ClementWalter
force-pushed
the
cw/add-balance-in-account
branch
from
d407679 to
b597d61
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 71.44% 71.90% +0.46%
==========================================
Files 45 47 +2
Lines 6118 6041 -77
==========================================
- Hits 4371 4344 -27
+ Misses 1747 1697 -50 ☔ View full report in Codecov by Sentry. |
ClementWalter
force-pushed
the
cw/add-balance-in-account
branch
from
8d069f5 to
d3f3afb
Compare
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this pull request
Nov 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.2
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
model.Statemaintains a dict for accounts balances.This is a mis conception due the the false belief that "we don't want
to fetch an account just to send ETH". But there is no way to send ETH
without making a CALL (apart in SELFDESTRUCT).
What is the new behavior?
The balance belongs to the Account instead (as in the ef tests json description for example).
Note: this is a preliminary work to run Kakarot in standalone (no syscall, ie. no Starknet) mode.