fix: fix early return for create

[Eikix]

Time spent on this PR: 0.2 day

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Resolves #795

What is the new behavior?

• add early return for collision in create
• add early return for unsufficient balance in create (value > 0)

[ClementWalter]

how many ef tests does this solve?
Also, I think that there is a place where the value is used to do early return and not add_transfer, that should be fixed

you add a lot of comments I don't fell bring any value to the codebase.

[Eikix]

Also, I think that there is a place where the value is used to do early return and not add_transfer, that should be fixed

In system operations, line 800, we handle transfer in CREATE, but adding an "if amount == 0" would probably disturb the references and result in revoked reference errors. Not sure how to handle this without an early return inside the add_transfer. But I agree this early return should probably not be used

[ClementWalter]

Also, I think that there is a place where the value is used to do early return and not add_transfer, that should be fixed

In system operations, line 800, we handle transfer in CREATE, but adding an "if amount == 0" would probably disturb the references and result in revoked reference errors. Not sure how to handle this without an early return inside the add_transfer. But I agree this early return should probably not be used

early return in add_transfer is fine for me. I was referring to this

https://github.com/ClementWalter/kakarot/blob/bff112a701d00e9e6991b9780ba66a2fad389f54/src/kakarot/instructions/system_operations.cairo#L238

that should then probably be removed since the add_transfer integrates it.

[ClementWalter]

I'm ok with the proposed changes in terms of code (though need to fix 2 tests). However I'm wondering if the proposed change implements the right behavior as it makes 30 ef-tests failing

[Eikix]

Blocked by an update on the ef-test runner

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (4c10873) 71.90% compared to head (c7f62b0) 72.11%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/kakarot/instructions/system_operations.cairo	61.53%	10 Missing ⚠️
src/kakarot/state.cairo	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   71.90%   72.11%   +0.21%     
==========================================
  Files          47       47              
  Lines        6041     6040       -1     
==========================================
+ Hits         4344     4356      +12     
+ Misses       1697     1684      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.