Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Fix bytecode is not written when starknet contract already exists #822

Conversation

ClementWalter
Copy link
Member

Time spent on this PR: 0.3

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #821

What is the new behavior?

Overwrite bytecode if stored bytecode len doesn't match account.code_len

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4c10873) 71.90% compared to head (fe40997) 71.84%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/data_availability/starknet.cairo 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   71.90%   71.84%   -0.06%     
==========================================
  Files          47       47              
  Lines        6041     6046       +5     
==========================================
  Hits         4344     4344              
- Misses       1697     1702       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementWalter ClementWalter merged commit 806ea6b into kkrt-labs:main Nov 23, 2023
5 of 7 checks passed
@ClementWalter ClementWalter deleted the cw/fix-bytecode-not-written-after-recreate branch November 23, 2023 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: accounts created at previously SELFDESTRUCT don't write bytecode
2 participants