-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN SDK 1.1.0 release branch #188
Conversation
* updating RN SDK to include badge count API * checking if method exists before calling it * added a comment
…dk into rel/1.1.0
846bcd1
to
1d0b230
Compare
Just curious - are we considering this to be a minor release only on rn/swift because this is primarily for badge stuff? |
You probably already thought about this but since we published the test apps for RN, we don't need to npm publish a pre release for RN SDK. May be once testing is done we repurpose this PR for the actual release? |
activesupport (7.0.8.6) | ||
activesupport (6.1.7.10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why we're going down a version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah not sure, it was autogenerated when I did bundle install
2.5.22 | ||
2.4.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question here
…dk into rel/1.1.0
…dk into rel/1.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI was failing on the example app, so we commented the part that builds the example app and tested manually on the react native test app and pod install succeeds. We will the fix CI in a following PR since it's not related to the changes here.
Included in this release branch: