Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN SDK 1.1.0 release branch #188

Merged
merged 23 commits into from
Jan 21, 2025
Merged

RN SDK 1.1.0 release branch #188

merged 23 commits into from
Jan 21, 2025

Conversation

belleklaviyo
Copy link
Contributor

@belleklaviyo belleklaviyo commented Jan 13, 2025

Included in this release branch:

  • bumped iOS SDK 4.0.0 -> 4.1.0
  • bumped Android SDK 3.0.0 -> 3.0.2
  • bumped RN version 1.0.0 -> 1.1.0
  • badge count bridging logic (from iOS to RN)
  • README updates to include badge count and point to Swift SDK README for install/setup instructions

@belleklaviyo belleklaviyo marked this pull request as ready for review January 14, 2025 14:53
@belleklaviyo belleklaviyo requested a review from a team as a code owner January 14, 2025 14:53
@belleklaviyo belleklaviyo changed the title RN SDK 1.1.0 release branch (WIP) RN SDK 1.1.0 release branch Jan 14, 2025
@dan-peluso
Copy link
Contributor

Just curious - are we considering this to be a minor release only on rn/swift because this is primarily for badge stuff?

@ajaysubra
Copy link
Collaborator

You probably already thought about this but since we published the test apps for RN, we don't need to npm publish a pre release for RN SDK. May be once testing is done we repurpose this PR for the actual release?

@belleklaviyo belleklaviyo changed the title (WIP) RN SDK 1.1.0 release branch RN SDK 1.1.0 release branch Jan 21, 2025
activesupport (7.0.8.6)
activesupport (6.1.7.10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why we're going down a version here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah not sure, it was autogenerated when I did bundle install

Comment on lines -103 to +105
2.5.22
2.4.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

Copy link
Collaborator

@ajaysubra ajaysubra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing on the example app, so we commented the part that builds the example app and tested manually on the react native test app and pod install succeeds. We will the fix CI in a following PR since it's not related to the changes here.

@belleklaviyo belleklaviyo merged commit cdc33e4 into master Jan 21, 2025
9 checks passed
@belleklaviyo belleklaviyo deleted the rel/1.1.0 branch January 21, 2025 22:21
@belleklaviyo belleklaviyo restored the rel/1.1.0 branch January 22, 2025 17:53
@belleklaviyo belleklaviyo deleted the rel/1.1.0 branch January 22, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants