Migrate to distribution/reference #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use github.com/docker/distribution/reference for parsing references. Fixes kleveross#209 Signed-off-by: Steve Larkin <[email protected]>
|
@gaocegege could you please merge this PR? |
|
CI blocks the automatic merge. I am merging it manually. |
|
@gaocegege could you please make a new release in GitHub? The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area cli
What this PR does / why we need it:
Use the tried and tested package github.com/docker/distribution/reference for parsing OCI references.
Which issue(s) this PR is related to:
Fixes #209
Special notes for your reviewer:
This patch uses the already-vendored package github.com/docker/distribution/reference. When the dependencies are upgraded we should switch to the CNCF-contributed package, which was factored out of the docker one and keeps the same API: github.com/distribution/reference
I chose to keep the existing
ReferenceAPI in ormb'socipackage as a facade instead of updating all call-sites to use github.com/docker/distribution/reference. If you prefer I am open to doing the latter also.The distribution/reference package has extensive tests so I only added a few here to regression-test the specific bug fixed by this change.
/cc @gaocegege
Does this PR introduce a user-facing change?: