Make sure we can use the activity more than once

klippa-app · May 19, 2020 · 641f6e9 · 641f6e9
1 parent e7e0e2a
commit 641f6e9
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/KlippaOCRAPI/Activities/ParseDocumentActivity.cs b/KlippaOCRAPI/Activities/ParseDocumentActivity.cs
@@ -81,15 +81,15 @@ public class ParseDocument: AsyncCodeActivity
         public OutArgument<APIResponse> APIResponse { get; set; }
 
         private HttpClient httpClient;
-        private MultipartFormDataContent formData;
-        private FileStream fs;
 
         public ParseDocument()
         {
             BasePath = "https://custom-ocr.klippa.com/api/v1";
             PDFTextExtraction = PDFTextExtractionType.Fast;
-            httpClient = new HttpClient();
-            formData = new MultipartFormDataContent();
+            httpClient = new HttpClient
+            {
+                Timeout = TimeSpan.FromSeconds(600)
+            };
         }
 
         protected override IAsyncResult BeginExecute(AsyncCodeActivityContext context, AsyncCallback callback, object state)
@@ -145,23 +145,18 @@ protected override void EndExecute(AsyncCodeActivityContext context, IAsyncResul
             }
             finally
             {
-                if (httpClient != null)
-                {
-                    httpClient.Dispose();
-                }
-                if (formData != null)
+                if (task.Result != null)
                 {
-                    formData.Dispose();
-                }
-                if (fs != null)
-                {
-                    fs.Dispose();
+                    task.Result.Dispose();
                 }
             }
         }
 
         Task<HttpResponseMessage> ExecuteAsync(CodeActivityContext context)
         {
+            MultipartFormDataContent formData = new MultipartFormDataContent();
+            FileStream fs = null;
+
             var basePath = BasePath.Get(context);
             var request = new HttpRequestMessage()
             {
@@ -225,8 +220,7 @@ Task<HttpResponseMessage> ExecuteAsync(CodeActivityContext context)
             }
 
             request.Content = formData;
-            request.Properties["RequestTimeout"] = TimeSpan.FromSeconds(60);
-            httpClient.Timeout = TimeSpan.FromSeconds(60);
+            request.Properties["RequestTimeout"] = TimeSpan.FromSeconds(600);
 
             return httpClient.SendAsync(request);
         }