Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileReader open mode so it is compatible with Kodi Omega #206

Merged
merged 3 commits into from
May 7, 2024

Conversation

phunkyfish
Copy link
Member

@phunkyfish phunkyfish commented Apr 20, 2024

v21.0.2

  • Update FileReader open mode so it is compatible with Kodi Omega

If the change to READ_NO_CACHE works, then try using : READ_NO_CACHE | READ_TRUNCATED | READ_BITRATE instead.

This was referenced Apr 20, 2024
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe put the whitespace cleanups in a separate commit? The diff is not reeadable, one can not really spot what actuallly has changed.

EDIT: nvm, you already did. I overlooked this, sorry.

@phunkyfish
Copy link
Member Author

@margro are you ok with this PR? Playback is essentially broken in Kodi Omega because the behaviour of the open file api call changed.

I know you keep this in sync with another source and I’m not sure if the whitespace commit is ok or not. I made that change because they are the only 2 files that are CRLF. The rest are all LF.

@phunkyfish phunkyfish requested a review from margro April 21, 2024 06:13
@phunkyfish phunkyfish merged commit 800078d into kodi-pvr:Omega May 7, 2024
8 checks passed
@phunkyfish phunkyfish deleted the file-reader-fix branch May 7, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants