Add Support for Static LoadBalancer IP in Offline Deployments #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idanbunimovich
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
This PR introduces the ability to specify a loadBalancerIP for the Service when using the LoadBalancer type. This is particularly useful for offline deployments where a static IP is required for the service to function reliably.
The changes allow users to provide a loadBalancerIP field in the values.yml file, ensuring flexibility for setups in air-gapped or isolated environments. The Service template has been updated to conditionally include this field if it is specified.
Key Changes:
Updated the Service template to support loadBalancerIP.
Modified the values.yml file to include the loadBalancerIP field.
Documented the usage of loadBalancerIP in the values.yml example.
Check List
V The title of my pull request is a short description of the changes
V This PR relates to some issue
V I have documented the changes made (if applicable)
X I have covered the changes with unit tests