Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-1066] Create Github action 1 #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ENG-1066] Create Github action 1 #61

wants to merge 1 commit into from

Conversation

eddiechayes
Copy link

No description provided.

@notion-workspace
Copy link

Create Github Action 1 (generate and test)

dphuang2
dphuang2 reviewed Aug 23, 2023
View reviewed changes
.github/workflows/generate.yaml
# Then runs konfig test and merges the PR if tests pass
generate_and_test:
runs-on: ubuntu-latest
needs: check_if_oas_modified # Runs serially after check_if_oas_modified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, cool I like the separation of concerns

dphuang2
dphuang2 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@dphuang2 dphuang2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first pass, lets figure out how to do testing to close this case

then we should follow up with adding the generation of this workflow to konfig init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dphuang2 dphuang2 dphuang2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddiechayes @dphuang2