Homepage 1.0 #62
Merged
Homepage 1.0 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed from shop: Konnected
stamped snippet
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
…o/shopify-dawn into feature/new-homepage
Committed from shop: Konnected
Fixes/dawnify compare kits
…cted-io/shopify-dawn into fixes/dawnify-compare-kits
This reverts commit 281b27a.
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
…cted-io/shopify-dawn into fixes/dawnify-compare-kits
Fixes/dawnify compare kits
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
Committed from shop: Konnected
…o/shopify-dawn into feature/new-homepage
…o/shopify-dawn into feature/new-homepage
|
@heythisisnate pls check if adaptiveheight feature (on mobile) of the banner slider works fine on your mobile device w/o flickering on slide change. https://nodemcu-smartthings.myshopify.com/?preview_theme_id=162338570555 slider height and dots position should adapt current slide item's height.
|
|
also, should we add the current BFCM campaign banner for the slider before it pushed to live?
|
|
I think it looks good! Yes, we should use the current Black Friday banner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://nodemcu-smartthings.myshopify.com/?preview_theme_id=162338570555
Applied 2 new sections here:
