Fix issues with caching internal function calls (#258)

konradhalas · Jul 17, 2024 · 45c2993 · 45c2993
1 parent 10a9ec4
commit 45c2993
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-Nothing yet.
+- Fix issues with caching internal function calls
 
 ## [1.8.1] - 2023-05-12
 

diff --git a/dacite/cache.py b/dacite/cache.py
@@ -8,7 +8,7 @@
 
 @lru_cache(maxsize=None)
 def cache(function: T) -> T:
-    return lru_cache(maxsize=get_cache_size())(function)  # type: ignore
+    return lru_cache(maxsize=get_cache_size(), typed=True)(function)  # type: ignore
 
 
 def set_cache_size(size: Optional[int]) -> None:

diff --git a/tests/test_types.py b/tests/test_types.py
@@ -399,3 +399,8 @@ class FakeType:
         _special = True
 
     assert extract_generic(FakeType, defaults) == defaults
+
+
+def test_optional_and_union_none_does_not_pollute_scope_via_caching():
+    is_generic(Optional[str])
+    is_generic_collection(str | None)