Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Add comments to assessment wizard & review components #1483

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

ibolton336
Copy link
Member

  • Add comments to assessment wizard sections
  • Allow comments to be viewed in assessment review screen

@ibolton336 ibolton336 changed the title Wire up comment in assessment wizard 👻 Add comments to assessment wizard & review components Oct 17, 2023
Add sections comments to question review screen

Signed-off-by: ibolton336 <[email protected]>
@ibolton336 ibolton336 force-pushed the add-comments-section branch from 3749ae3 to 653541c Compare October 18, 2023 19:47
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba66b4f) 40.69% compared to head (5559468) 40.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   40.69%   40.72%   +0.03%     
==========================================
  Files         139      139              
  Lines        4463     4466       +3     
  Branches     1067     1069       +2     
==========================================
+ Hits         1816     1819       +3     
  Misses       2552     2552              
  Partials       95       95              
Flag Coverage Δ
client 40.72% <100.00%> (+0.03%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/api/models.ts 100.00% <ø> (ø)
client/src/app/pages/assessment/form-utils.ts 100.00% <100.00%> (ø)
client/src/app/queries/businessservices.ts 30.76% <100.00%> (ø)
client/src/app/utils/model-utils.tsx 35.06% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibolton336 ibolton336 merged commit 07a31c0 into konveyor:main Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants