Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Don't auto select source labels when setting a target #1485

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Oct 20, 2023

  • Only include explicitly selected source labels from a selected target

- Remove sources from form labels sources and only include explicitly added sources

Signed-off-by: ibolton336 <[email protected]>
galt-tr

This comment was marked as spam.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (07a31c0) 40.72% compared to head (d9c87f9) 40.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   40.72%   40.72%   -0.01%     
==========================================
  Files         139      139              
  Lines        4466     4469       +3     
  Branches     1069     1069              
==========================================
+ Hits         1819     1820       +1     
- Misses       2552     2554       +2     
  Partials       95       95              
Flag Coverage Δ
client 40.72% <11.11%> (-0.01%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/app/pages/applications/analysis-wizard/schema.ts 89.74% <ø> (ø)
.../app/pages/applications/analysis-wizard/review.tsx 18.60% <0.00%> (ø)
...s/applications/analysis-wizard/analysis-wizard.tsx 61.98% <25.00%> (-0.73%) ⬇️
...pages/applications/analysis-wizard/set-options.tsx 15.68% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dymurray dymurray merged commit abafafa into konveyor:main Oct 20, 2023
7 checks passed
@ibolton336
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants