Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descheduler: check nodemetrics cr is expired or not when descheduling #1721

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Oct 24, 2023

Ⅰ. Describe what this PR does

case:
The nodemetric cr has not been updated for a long time, e.g. the koordlet was deleted, but the load information written last time is particularly high, causing pods on this node being evicted all the time, even though the actual load was low.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

check nodemetrics cr is expired or not when descheduling

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp October 24, 2023 12:58
@lucming lucming force-pushed the fix-nodemtric-expired branch 2 times, most recently from 0199231 to d9d1111 Compare October 24, 2023 13:03
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cae8705) 65.94% compared to head (cb9b83f) 65.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   65.94%   65.97%   +0.02%     
==========================================
  Files         386      386              
  Lines       41922    41934      +12     
==========================================
+ Hits        27647    27664      +17     
+ Misses      12228    12224       -4     
+ Partials     2047     2046       -1     
Flag Coverage Δ
unittests 65.97% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/descheduler/apis/config/v1alpha2/defaults.go 14.05% <100.00%> (+1.41%) ⬆️
...duler/framework/plugins/loadaware/low_node_load.go 74.72% <100.00%> (ø)
...ler/apis/config/validation/validation_loadaware.go 0.00% <0.00%> (ø)
...er/framework/plugins/loadaware/utilization_util.go 87.50% <25.00%> (-1.51%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucming lucming force-pushed the fix-nodemtric-expired branch 2 times, most recently from 730765f to ef703b2 Compare October 25, 2023 02:55
Signed-off-by: lucming <[email protected]>

descheduler: check nodemetrics cr is expired or not when descheduling
@lucming lucming force-pushed the fix-nodemtric-expired branch from ef703b2 to cb9b83f Compare October 25, 2023 07:27
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e6ecd29 into koordinator-sh:main Oct 25, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants