apis: add host application metric to node metric crd #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
+ Coverage 65.95% 66.04% +0.08%
==========================================
Files 386 386
Lines 41974 42049 +75
==========================================
+ Hits 27686 27773 +87
+ Misses 12240 12228 -12
Partials 2048 2048
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
10 tasks
jasonliu747
force-pushed
the
add-host-app-metric
branch
from
055ef0a to
0ba9c50
Compare
Signed-off-by: 佑祎 <[email protected]>
zwzhang0107
force-pushed
the
add-host-app-metric
branch
from
0ba9c50 to
9f2cc89
Compare
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
add apis for reporting metric of host application, this can be also used for reporting the whole yarn task resource usage.
For out-of-band applications with batch priority, resource calculation of batch allocatable should excluded their usage, otherwise it will be count into system usage.
Ⅱ. Does this pull request fix one issue?
#1639
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test