-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support hugepage reporting #1744
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 66.08% 66.32% +0.23%
==========================================
Files 388 395 +7
Lines 42373 43536 +1163
==========================================
+ Hits 28003 28874 +871
- Misses 12296 12512 +216
- Partials 2074 2150 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/koordlet/metricsadvisor/collectors/nodeinfo/node_info_collector_test.go
Outdated
Show resolved
Hide resolved
/lgtm |
@peiqiaoWang please add a feature-gate for it, thanks. |
I think we need to clarify whether koordlet needs to do something on huge-page considering NUMA (i.e. set cpuset.mems or not set yet) |
@zwzhang0107 kubelet will do this thing that set value on hugetlb.1GB.limit_in_bytes. |
pkg/koordlet/statesinformer/impl/states_noderesourcetopology.go
Outdated
Show resolved
Hide resolved
@peiqiaoWang yep, i mean the cpuset.mems. We should add some comments to clarify whether limit the hugepages on single numa node. |
这个功能只支持大页上报,设置numa信息由调度器分配,然后作用到pod是由csi根据调度器分配的numa信息把预分配大页绑上去,此处是否设置绑定namespace的numa使用关系倒是不大 |
Signed-off-by: peiqiao.wpq <[email protected]>
Add some comments in |
/lgtm |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
支持了大页上报的功能,包括2M和1G大页
Ⅱ. Does this pull request fix one issue?
无
Ⅲ. Describe how to verify it
可通过k8s
kubectl get noderesourcetopologies
查看Ⅳ. Special notes for reviews
支持了大页内存的上报,其中原本的内存memory上送的数目也进行了修改,将上报内存 设置为 总内存大小 减去 大页内存的数量。
func (s *nodeTopoInformer) calTopologyZoneList(nodeCPUInfo *metriccache.NodeCPUInfo) 需重点看下。
V. Checklist
make test