-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colocationprofile: support mutating pod labels and annotations with mapping #1781
colocationprofile: support mutating pod labels and annotations with mapping #1781
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 66.42% 66.42% -0.01%
==========================================
Files 396 396
Lines 43739 43753 +14
==========================================
+ Hits 29053 29061 +8
- Misses 12525 12532 +7
+ Partials 2161 2160 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
why not set the pod.labels["koordinator.sh/core-sched-group-id"] = pod.labels["app-user-id"], |
It is also supported in this PR. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
8f5ecf9
to
300a0f6
Compare
As discussed offline, the field |
/lgtm |
/lgtm |
300a0f6
to
97aa7e0
Compare
…ding to mapping Signed-off-by: saintube <[email protected]>
97aa7e0
to
dff1b78
Compare
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
It can be used to set the core scheduling group IDs (#1728) of the pods according to a given pod label.
e.g.
V. Checklist
make test