Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init interferencemanager #982

Conversation

songtao98
Copy link
Contributor

Signed-off-by: songtao98 [email protected]

Ⅰ. Describe what this PR does

After collecting metrics for interference detection, we propose a new component interference-manager to parse metrics from prometheus, aggregate these parsed CPI, PSI... metrics into histograms. Based on those histograms some statistics can be calculated easily and can be used for interference analysis.

This PR initialize this component and implement a simple histogram ExponentialHistogram and related algorithms.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

This PR is hold for some time, more details are to be implemented recently.

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: songtao98 <[email protected]>
@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes February 2, 2023 12:48
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@songtao98
Copy link
Contributor Author

/hold

@zwzhang0107
Copy link
Contributor

/hold

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 66.97% // Head: 66.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9653b7c) compared to base (691bddd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   66.97%   66.98%           
=======================================
  Files         244      244           
  Lines       28318    28335   +17     
=======================================
+ Hits        18966    18979   +13     
- Misses       8052     8053    +1     
- Partials     1300     1303    +3     
Flag Coverage Δ
unittests 66.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
pkg/scheduler/plugins/reservation/hook.go 75.62% <0.00%> (-1.39%) ⬇️
...er/apis/config/validation/validation_pluginargs.go 63.63% <0.00%> (-0.65%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
...duler/framework/plugins/loadaware/low_node_load.go 70.58% <0.00%> (+3.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@songtao98
Copy link
Contributor Author

interference manager will be moved into new repo koordetector, check PR koordinator-sh/koordetector#2 and this one is closed now

@songtao98 songtao98 closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants