Implement Tensor from_raw_parts #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbin
reviewed
Dec 27, 2024
edgarriba
commented
Dec 27, 2024
edgarriba
commented
Dec 28, 2024
crates/kornia-tensor/src/storage.rs
Outdated
| // Safety: | ||
| // TensorStorage is thread safe if the allocator is thread safe. | ||
| unsafe impl<T, A: TensorAllocator> Send for TensorStorage<T, A> {} | ||
| unsafe impl<T, A: TensorAllocator> Sync for TensorStorage<T, A> {} | ||
|
|
||
| impl<T, A: TensorAllocator> Drop for TensorStorage<T, A> { | ||
| fn drop(&mut self) { | ||
| self.alloc | ||
| .dealloc(self.ptr.as_ptr() as *mut u8, self.layout); | ||
| if !self.managed_by_external { |
There was a problem hiding this comment.
@gbin had to add this flag here to prevent double deallocation as I couldn't find a way to prevent gstreamer deallocating the memory
edgarriba
commented
Dec 29, 2024
| return Ok(None); | ||
| }; | ||
|
|
||
| let frame_buffer = std::mem::ManuallyDrop::new(frame_buffer); |
There was a problem hiding this comment.
@gbin having a bit of trouble by trying to prevent gstreamer to deallocate the buffer. Do you have any insights here ?
edgarriba
commented
Dec 29, 2024
|
|
||
| // Check for null pointer | ||
| if !ptr.is_null() { | ||
| //unsafe { alloc::dealloc(ptr, layout) } |
There was a problem hiding this comment.
@gbin by commenting this line seems to do the job but i don't think it's correct. The behavior I'm seeing is that I never enter in this branch statement but gstreamer tries to allocate an invalid pointer. A bit weird -- might be missing something fundamental ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.