Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gradle): bump dagger from 2.54 to 2.55 #128

Closed
wants to merge 8 commits into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps dagger from 2.54 to 2.55.
Updates com.google.dagger:dagger from 2.54 to 2.55

Release notes

Sourced from com.google.dagger:dagger's releases.

Dagger 2.55

Notable/breaking changes

  • Added support for injecting jakarta.inject.Provider. This should be usable anywhere javax.inject.Provider is usable. Note that this technically comes with a breaking change to disallow providing jakarta.inject.Provider types in the same way it is disallowed for javax.inject.Provider. (caa7e178b)
  • Fixed a number of binding graph related issues. These fixes can be enabled with, -Adagger.useBindingGraphFix=ENABLED, but due to this sometimes being a breaking change we’ve set the default behavior to “disabled” for now. We will flip the default to “enabled” in a future release, and eventually remove the flag altogether. Enabling this feature can fix a number of confusing error messages. See https://dagger.dev/dev-guide/compiler-options#useBindingGraphFix for more details.

Bug fixes

  • Fixed #4549: Fixed incremental processing for LazyClassKey proguard files by adding the originating element to the writeResource call. (98a027541)
Commits
  • 14ad560 2.55 release
  • 7ca9977 Add binary compatibility validator to the Gradle projects
  • 4cd83cb Add documentation for dagger.useBindingGraphFix compiler option.
  • 8b4f9b6 Add maven publish plugin to Gradle projects.
  • 9daa0ae Wire resource configuration while keeping the Bazel project structure.
  • 3418609 Move JDK toolchain, Kotlin language and JVM target configuration to conventio...
  • 0927b9a Add flag to control LegacyBindingGraphFactory usage.
  • 1620e92 Add Github CI step and action for building with Gradle
  • c43783a Initial setup of Gradle as a build system for Dagger
  • 98a0275 Fix LazyClassKey proguard file issues.
  • Additional commits viewable in compare view

Updates com.google.dagger:dagger-compiler from 2.54 to 2.55

Release notes

Sourced from com.google.dagger:dagger-compiler's releases.

Dagger 2.55

Notable/breaking changes

  • Added support for injecting jakarta.inject.Provider. This should be usable anywhere javax.inject.Provider is usable. Note that this technically comes with a breaking change to disallow providing jakarta.inject.Provider types in the same way it is disallowed for javax.inject.Provider. (caa7e178b)
  • Fixed a number of binding graph related issues. These fixes can be enabled with, -Adagger.useBindingGraphFix=ENABLED, but due to this sometimes being a breaking change we’ve set the default behavior to “disabled” for now. We will flip the default to “enabled” in a future release, and eventually remove the flag altogether. Enabling this feature can fix a number of confusing error messages. See https://dagger.dev/dev-guide/compiler-options#useBindingGraphFix for more details.

Bug fixes

  • Fixed #4549: Fixed incremental processing for LazyClassKey proguard files by adding the originating element to the writeResource call. (98a027541)
Commits
  • 14ad560 2.55 release
  • 7ca9977 Add binary compatibility validator to the Gradle projects
  • 4cd83cb Add documentation for dagger.useBindingGraphFix compiler option.
  • 8b4f9b6 Add maven publish plugin to Gradle projects.
  • 9daa0ae Wire resource configuration while keeping the Bazel project structure.
  • 3418609 Move JDK toolchain, Kotlin language and JVM target configuration to conventio...
  • 0927b9a Add flag to control LegacyBindingGraphFactory usage.
  • 1620e92 Add Github CI step and action for building with Gradle
  • c43783a Initial setup of Gradle as a build system for Dagger
  • 98a0275 Fix LazyClassKey proguard file issues.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link
Author

dependabot bot commented on behalf of github Jan 13, 2025

The following labels could not be found: version-bump.

niloc132 and others added 8 commits January 20, 2025 08:28
Our slack actions appear all to be workflows, assigned the
webhook-trigger accordingly.

Also added build summary URLs for nightly check and publish.

Follow-up deephaven#6384
deephaven#6577)

Added a systemic_obj_tracker.py module which allows users to
enable/disable systemic object marking on the current thread.
…res to `UpdateBy` (deephaven#6566)

## Groovy Examples
```
table = emptyTable(1000).update("key=randomInt(0,10)", "intCol=randomInt(0,1000)")

// zero-key
t_summary = table.updateBy([
    CumCountWhere("running_gt_500", "intCol > 500"),
    RollingCountWhere(50, "windowed_gt_500", "intCol > 500"),
    ])

// bucketed
t_summary = table.updateBy([
    CumCountWhere("running_gt_500", "intCol > 500"),
    RollingCountWhere(50, "windowed_gt_500", "intCol > 500"),
    ], "key")
```

## Python Examples
```
from deephaven import empty_table
from deephaven.updateby import cum_count_where, rolling_count_where_tick

table = empty_table(1000).update(["key=randomInt(0,10)", "intCol=randomInt(0,1000)"])

# zero-key
t_summary = table.update_by([
    cum_count_where(col="running_gt_500", filters="intCol > 500"),
    rolling_count_where_tick(rev_ticks=50, col="windowed_gt_500", filters="intCol > 500"),
    ])

# bucketed
t_summary_bucketed = table.update_by([
    cum_count_where(col="running_gt_500", filters="intCol > 500"),
    rolling_count_where_tick(rev_ticks=50, col="windowed_gt_500", filters="intCol > 500"),
    ], by="key")
```

## Performance Notes

TL:DR Performance compares very well.

`RollingCountWhere()` has near identical performance to the comparison
benchmarks (can be faster depending on the complexity of the filter.
`CumCountWhere()` also compares well to `Ema()`but can't catch up to
zero-key `CumSum()`, which is is remarkably fast.

Comparing `CumCountWhere` to `CumSum` and `Ema`:
```
120000000
avg of 2

ZeroKey
CumSum	137.36250
Ema	449.5528125
CumCountWhereConstant	475.9980005
CumCountWhereMatch	649.9689995
CumCountWhereRange	654.322250
CumCountWhereMultiple	695.4477915
CumCountWhereMultipleOr	704.900583

Bucketed - 250 buckets
CumSum	2979.1730005
Ema	3024.152458
CumCountWhereConstant	2569.7280835
CumCountWhereMatch	3031.6534795
CumCountWhereRange	3030.5433335
CumCountWhereMultiple	3052.597625
CumCountWhereMultipleOr	3059.911729

Bucketed - 640 buckets
CumSum	3827.299833
Ema	3880.2538125
CumCountWhereConstant	3416.4387715
CumCountWhereMatch	3906.691333
CumCountWhereRange	3902.3064375
CumCountWhereMultiple	3967.1584795
CumCountWhereMultipleOr	3925.0775205
```

Comparing `RollingCountWhere` to `RollingCount` and `RollingSum`:
```
120000000
avg of 2

ZeroKey
RollingCount	1511.7957295
RollingSum	1513.6013545
RollingCountWhereConstant	1403.2817915
RollingCountWhereMatch	1453.9323125
RollingCountWhereRange	1764.2137915
RollingCountWhereMultiple	1576.4896255
RollingCountWhereMultipleOr	1541.5631455

Bucketed - 250 buckets
RollingCount	3468.7696665
RollingSum	3326.047792
RollingCountWhereConstant	2858.677771
RollingCountWhereMatch	3327.958604
RollingCountWhereRange	3347.961083
RollingCountWhereMultiple	3429.413562
RollingCountWhereMultipleOr	3364.244104

Bucketed - 640 buckets
RollingCount	4310.4265835
RollingSum	4286.427479
RollingCountWhereConstant	3869.1892705
RollingCountWhereMatch	4333.8479375
RollingCountWhereRange	4269.3454375
RollingCountWhereMultiple	4290.0618545
RollingCountWhereMultipleOr	4346.8478535
```
DataIndex, particularly when used for where() filters had missing
parallelization opportunities; and would read more data than strictly
necessary to satisfy the filter.

---------

Co-authored-by: Ryan Caudy <[email protected]>
Bumps `dagger` from 2.54 to 2.55.

Updates `com.google.dagger:dagger` from 2.54 to 2.55
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.54...dagger-2.55)

Updates `com.google.dagger:dagger-compiler` from 2.54 to 2.55
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](google/dagger@dagger-2.54...dagger-2.55)

---
updated-dependencies:
- dependency-name: com.google.dagger:dagger
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.dagger:dagger-compiler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Author

dependabot bot commented on behalf of github Jan 26, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/dagger-2.55 branch January 26, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants