Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive param for centeredSlides #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Directive param for centeredSlides #58

wants to merge 1 commit into from

Conversation

alvarosabu
Copy link

Added param fo directive to setup if the active slider cand be in the center

Copy link

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will be better to use real swiper api properties.

I should be preferable to use centeredSlides attribute name rather than centered.

In my opinion, We could use all directive attributes to extends our params like :

link: function(scope, element, attrs) {
...
$scope.params = angular.extend({}, $attrs);
...

In this way we could use $scope.params in controller function which will contains all swiper well-named arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants