Skip to content

Commit

Permalink
fix(sdk): Update sdk to 1.6.5 with new kfp 1.8.20 to address kubernet…
Browse files Browse the repository at this point in the history
…es cves (#1206)

* update sdk to 1.6.5 with new kfp 1.8.20 to address kubernetes cves

* fix tests to use the latest k8s version
  • Loading branch information
Tomcli authored Apr 11, 2023
1 parent 57d2847 commit 2fdcd81
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions sdk/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ the Tekton YAML instead of Argo YAML. Since the KFP SDK was not designed and imp
_monkey-patching_ was used to replace non-class methods and functions at runtime.

In order for the _monkey patch_ to work properly, the `kfp-tekton` compiler source code has to be aligned with a
specific version of the `kfp` SDK compiler. As of now the `kfp-tekton` SDK version is `1.6.4` which is aligned with KFP
SDK version [`1.8.19`](https://pypi.org/project/kfp/1.8.19/).
specific version of the `kfp` SDK compiler. As of now the `kfp-tekton` SDK version is `1.6.5` which is aligned with KFP
SDK version [`1.8.20`](https://pypi.org/project/kfp/1.8.20/).


## Adding New Code
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp_tekton/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

__version__ = '1.6.4'
__version__ = '1.6.5'

from ._client import TektonClient # noqa F401
from .k8s_client_helper import env_from_secret # noqa F401
2 changes: 1 addition & 1 deletion sdk/python/requirements.in
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
kfp>=1.8.10,<1.8.20
kfp>=1.8.10,<1.8.21
kfp-tekton-server-api>=1.5.0
2 changes: 1 addition & 1 deletion sdk/python/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ idna==2.10
# via requests
jsonschema==3.2.0
# via kfp
kfp==1.8.19
kfp==1.8.20
# via -r sdk/python/requirements.in
kfp-pipeline-spec==0.1.16
# via kfp
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
#
# To create a distribution for PyPi run:
#
# $ export KFP_TEKTON_VERSION=1.6.4-rc1
# $ export KFP_TEKTON_VERSION=1.6.5-rc1
# $ python3 setup.py sdist
# $ twine check dist/kfp-tekton-${KFP_TEKTON_VERSION/-rc/rc}.tar.gz
# $ twine upload --repository pypi dist/kfp-tekton-${KFP_TEKTON_VERSION/-rc/rc}.tar.gz
#
# ... or:
#
# $ make distribution KFP_TEKTON_VERSION=1.6.4-rc1
# $ make distribution KFP_TEKTON_VERSION=1.6.5-rc1
#
# =============================================================================

Expand Down Expand Up @@ -59,7 +59,7 @@
# NOTICE, after any updates to the following, ./requirements.in should be updated
# accordingly.
REQUIRES = [
"kfp>=1.8.10,<1.8.20",
"kfp>=1.8.10,<1.8.21",
"kfp-tekton-server-api>=1.5.0"
]

Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/compiler/k8s_helper_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def test_sanitize_k8s_container_attribute(self):
timeout_seconds='777'
)) \
.set_lifecycle(lifecycle=k8s_client.V1Lifecycle(
post_start=k8s_client.V1Handler(
post_start=k8s_client.V1LifecycleHandler(
_exec=k8s_client.V1ExecAction(command=[11, 22, 33]),
http_get=k8s_client.V1HTTPGetAction(
host=11,
Expand All @@ -194,7 +194,7 @@ def test_sanitize_k8s_container_attribute(self):
scheme=66),
tcp_socket=k8s_client.V1TCPSocketAction(host=555, port='666')
),
pre_stop=k8s_client.V1Handler(
pre_stop=k8s_client.V1LifecycleHandler(
_exec=k8s_client.V1ExecAction(command=[11, 22, 33]),
http_get=k8s_client.V1HTTPGetAction(
host=11,
Expand Down

0 comments on commit 2fdcd81

Please sign in to comment.