Skip to content

Commit

Permalink
fix(backend): Fix broken dependantTasks in ParallelFor
Browse files Browse the repository at this point in the history
Signed-off-by: Giulio Frasca <[email protected]>
  • Loading branch information
gmfrasca committed Oct 3, 2024
1 parent 0ea9187 commit 02e27f0
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions backend/src/v2/compiler/argocompiler/dag.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,10 @@ func (c *workflowCompiler) iteratorTask(name string, task *pipelinespec.Pipeline
// Set up Loop Control Template
loopDriverArgoName := name + "-loop-driver"
loopDriverInputs := dagDriverInputs{
component: componentSpecPlaceholder,
parentDagID: parentDagID,
task: taskJson, // TODO(Bobgy): avoid duplicating task JSON twice in the template.
component: componentSpecPlaceholder,
parentDagID: parentDagID,
task: taskJson, // TODO(Bobgy): avoid duplicating task JSON twice in the template.
iterationIndex: "0",
}
loopDriver, loopDriverOutputs, err := c.dagDriverTask(loopDriverArgoName, loopDriverInputs)
if err != nil {
Expand Down Expand Up @@ -356,7 +357,7 @@ func (c *workflowCompiler) iterationItemTask(name string, task *pipelinespec.Pip
if err != nil {
return nil, err
}
driver.Depends = depends(task.GetDependentTasks())
//driver.Depends = depends(task.GetDependentTasks()) # TODO(gfrasca): Handled already by root task

iterationCount := intstr.FromString(driverOutputs.iterationCount)
iterationTasks, err := c.task(
Expand Down

0 comments on commit 02e27f0

Please sign in to comment.