Skip to content

Commit

Permalink
chore: Change command to apply manifests in the docs (#10864)
Browse files Browse the repository at this point in the history
Signed-off-by: Ricardo M. Oliveira <[email protected]>
  • Loading branch information
rimolive authored Jun 5, 2024
1 parent 45f3457 commit 24424ba
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion backend/src/v2/test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ Some samples can be used as examples for various cases:

1. Q: I'm getting error `main.go:56] Failed to execute component: unable to get pipeline with PipelineName "pipeline-with-lightweight-io" PipelineRunID "pipeline-with-lightweight-io-pmxzr": Failed PutParentContexts(parent_contexts:{child_id:174 parent_id:173}): rpc error: code = Unimplemented desc =`.

A: You need to upgrade metadata-grpc-service deployment to 1.0.0+. KFP manifest master branch includes the upgrade, but it hasn't been released yet. Therefore, you need to install KFP standalone from master: `kubectl apply -k manifests/kustomize/env/dev`.
A: You need to upgrade metadata-grpc-service deployment to 1.0.0+. KFP manifest master branch includes the upgrade, but it hasn't been released yet. Therefore, you need to install KFP standalone from master: `kustomize build manifests/kustomize/env/dev | kubectl apply -f -`.

## Implementation Details

Expand Down
4 changes: 2 additions & 2 deletions manifests/kustomize/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ Install:

```bash
KFP_ENV=platform-agnostic
kubectl apply -k cluster-scoped-resources/
kustomize build cluster-scoped-resources/ | kubectl apply -f -
kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s
kubectl apply -k "env/${KFP_ENV}/"
kustomize build "env/${KFP_ENV}/" | kubectl apply -f -
kubectl wait pods -l application-crd-id=kubeflow-pipelines -n kubeflow --for condition=Ready --timeout=1800s
kubectl port-forward -n kubeflow svc/ml-pipeline-ui 8080:80
```
Expand Down
4 changes: 2 additions & 2 deletions manifests/kustomize/env/aws/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ Follow this [doc](https://awslabs.github.io/kubeflow-manifests/docs/deployment/r
5. Install

```
kubectl apply -k ../../cluster-scoped-resources
kustomize build ../../cluster-scoped-resources | kubectl apply -f -
# If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again
# kubectl delete -k ../../cluster-scoped-resources
kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s
kubectl apply -k ./
kustomize build ./ | kubectl apply -f -
# If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again
# kubectl delete -k ./
Expand Down
4 changes: 2 additions & 2 deletions manifests/kustomize/sample/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ gsutil mb -p myProjectId gs://myBucketName/
6. Install

```
kubectl apply -k sample/cluster-scoped-resources/
kustomize build sample/cluster-scoped-resources/ | kubectl apply -f -
kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s
kubectl apply -k sample/
kustomize build sample/ | kubectl apply -f -
# If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again
# kubectl delete -k sample/
Expand Down
2 changes: 1 addition & 1 deletion manifests/kustomize/sample/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ namespace: kubeflow
#### Customization ###
# 1. Change values in params.env file
# 2. Change values in params-db-secret.env file for CloudSQL username and password
# 3. kubectl apply -k ./
# 3. kustomize build ./ | kubectl apply -f -
####

0 comments on commit 24424ba

Please sign in to comment.