Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump requests-toolbelt to 1.0.0 fixes #10470 #10762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonDR-Boltzmann
Copy link

@SimonDR-Boltzmann SimonDR-Boltzmann commented Apr 29, 2024

Description of your changes:

Bumps requests-toolbelt from 0.9.1 to 1.0.0 (see #10470)

Checklist:

Copy link

Hi @SimonDR-Boltzmann. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rimolive
Copy link
Member

/ok-to-test

@rimolive
Copy link
Member

rimolive commented Apr 29, 2024

@SimonDR-Boltzmann I believe this is not the only place to upgrade requests-toolbelt. Looking at the entire repo, I see at least 8 other occurrences of that Python package. I'm new to the kfp code, so I'm unsure what the root requirements.txt does in the code, but I can tell you that the ones inside backend/ and sdk/python are the most important ones. And there's the test/kfp-functional-test/requirements.txt file to run the functional tests with that new dependency version.

That being said, ensure that all occurrences of that package are upgraded to 1.1.0 version.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Apr 29, 2024
@SimonDR-Boltzmann
Copy link
Author

@SimonDR-Boltzmann I believe this is not the only place to upgrade requests-toolbelt. Looking at the entire repo, I see at least 8 other occurrences of that Python package. I'm new to the kfp code, so I'm unsure what the root requirements.txt does in the code, but I can tell you that the ones inside backend/ and sdk/python are the most important ones. And there's the test/kfp-functional-test/requirements.txt file to run the functional tests with that new dependency version.

That being said, ensure that all occurrences of that package are upgraded to 1.1.0 version.

@rimolive You're right, I should have checked. It also seems the 1.1.0 is not on pypi yet, so I've bumped to 1.0.0 instead

@SimonDR-Boltzmann SimonDR-Boltzmann changed the title chore: bump requests-toolbelt to 1.1.0 fixes #10470 chore: bump requests-toolbelt to 1.0.0 fixes #10470 Apr 29, 2024
@rimolive
Copy link
Member

/test kubeflow-pipeline-e2e-test

@SimonDR-Boltzmann
Copy link
Author

@rimolive I could use your help debugging these failed tests, I'm not sure what the CancelledErrors mean, and I get a 403 when I click on the experiment/run details links.

@rimolive
Copy link
Member

@SimonDR-Boltzmann Just rebase and I believe the new Github Action tests will run.

Copy link

google-oss-prow bot commented Jun 17, 2024

@SimonDR-Boltzmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test 3d7827e link false /test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test 3d7827e link false /test kubeflow-pipeline-e2e-test
kfp-kubernetes-execution-tests 3d7827e link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SimonDR-Boltzmann
Copy link
Author

@SimonDR-Boltzmann Just rebase and I believe the new Github Action tests will run.

@rimolive It seems the tests still fail, but I still can't seem to access the relevant logs to see what's going on.

@hbelmiro
Copy link
Contributor

@SimonDR-Boltzmann you can ignore those tests. They are all optional.
We can see it here.

@github-actions github-actions bot added the Stale label Aug 18, 2024
@gregsheremeta
Copy link
Contributor

@SimonDR-Boltzmann please rebase this PR. We've done some test fixes, and maybe everything will just pass now.

@rimolive
Copy link
Member

@SimonDR-Boltzmann May I ask to rebase again? We migrated most of these tests to GitHub actions, now we can run propoer tests in your PR

@rimolive
Copy link
Member

/rerun-all

@SimonDR-Boltzmann
Copy link
Author

@SimonDR-Boltzmann There are some failling tests. Can you take a look?

@rimolive Apart from the

E       AssertionError: Pipeline components-preprocess ended with incorrect status: FAILED. More info: http://localhost:8888/#/runs/details/c86fcaeb-9963-4272-b6e1-817d8429d381
E       assert 'FAILED' == 'SUCCEEDED'
E         - SUCCEEDED
E         + FAILED

I can't really tell what's the cause of the errors. I'm having some trouble testing locally, could you point me in the right direction?

@gregsheremeta
Copy link
Contributor

I tried to run the tests locally as well (to see if I could help you out) and building images fails for me:

sha256:f326c34ea3fa9c3e2a71ffb6f85986c988a4d0bdc270b28fe3642502426fc125
The push refers to repository [kind-registry:5000/apiserver]
Get "https://kind-registry:5000/v2/": dial tcp: lookup kind-registry: no such host
Failed to build apiserver image.

I might be doing something wrong. It's my first time trying to do this.

Anyone know if we have documentation somewhere for running these e2e kind tests locally?

@diegolovison
Copy link
Contributor

/hold

requirements.txt Outdated Show resolved Hide resolved
sdk/python/requirements.txt Show resolved Hide resolved
@@ -85,7 +85,7 @@ requests==2.32.2
# requests-toolbelt
requests-oauthlib==2.0.0
# via kubernetes
requests-toolbelt==0.10.1
requests-toolbelt==1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you execute pip-compile requirements.in to genereta the requirements.txt?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but now the requests-toolbelt version is back to 0.10.1 here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check the dependency tree and see what library is requesting requests-toolbelt be with 0.10.1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kfp(==2.9.0), but I'm not sure how to fix that without releasing and versioning the other change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chensun what we should do in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chensun any idea?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chensun could you take a look?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegolovison @SimonDR-Boltzmann I believe this is because it's installing kfp from pypi repo, which still uses the old library version. What you could try is temporarily test adding the git+ssh entry in requirements.in pointing to your branch and see if pip-compile requirements.in upgrades to 1.0.

cc @gregsheremeta for awareness.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests succeed when I do this (see https://github.com/kubeflow/pipelines/pull/10762/files#diff-bd584e00f9357e94370a0ebb8f92990519014c49c20206352a17c430f3b79327R2).
I did have to specify requests-toolbelt==1.0.0 in the requirements.in before pip-compile used the new version, but there were no conflicts.

Shall I now remove the changes in test/kfp-functional-test, for final review?

Copy link
Author

@SimonDR-Boltzmann SimonDR-Boltzmann Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the changes in test/kfp-functional-test.

@hbelmiro
Copy link
Contributor

/rerun-all

@smthngslv
Copy link

Hello! Can this be merged?

@diegolovison
Copy link
Contributor

No. We need to fix #10762 (comment)

@SimonDR-Boltzmann SimonDR-Boltzmann force-pushed the sdr-requests-toolbelt branch 2 times, most recently from 371901f to 41d9344 Compare November 8, 2024 15:18
@SimonDR-Boltzmann
Copy link
Author

/rerun-all

@SimonDR-Boltzmann
Copy link
Author

Could someone with the right permissions trigger rerunning of the tests?

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 26, 2024
@HumairAK HumairAK added this to the KFP SDK 2.12 milestone Dec 3, 2024
@HumairAK
Copy link
Collaborator

HumairAK commented Dec 3, 2024

cc @chensun

Signed-off-by: Simon De Ridder <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

hbelmiro commented Jan 2, 2025

/ok-to-test

Copy link

github-actions bot commented Jan 2, 2025

Approvals successfully granted for pending runs.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed All CI tests on a pull request have passed do-not-merge/hold lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants