Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: kubeflow-pipeline-upgrade-test migrated to GitHub Actions #10932

Merged
merged 1 commit into from
Jul 1, 2024
Merged

test: kubeflow-pipeline-upgrade-test migrated to GitHub Actions #10932

merged 1 commit into from
Jul 1, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jun 20, 2024 •
edited
Loading

This PR depends on:

Description of your changes:
Resolves: #10931

PR to remove kubeflow-pipeline-upgrade-test from GoogleCloudPlatform/oss-test-infra

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot requested review from chensun and zijianjoy June 20, 2024 19:33
@hbelmiro hbelmiro force-pushed the kubeflow-pipeline-upgrade-test branch 5 times, most recently from edca954 to ebfb8f4 Compare June 23, 2024 16:40
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Jun 23, 2024
@hbelmiro hbelmiro mentioned this pull request Jun 23, 2024
Merged
@hbelmiro hbelmiro marked this pull request as ready for review June 23, 2024 16:52
@google-oss-prow google-oss-prow bot requested a review from jlyaoyuli June 23, 2024 16:53
@hbelmiro
Copy link
Contributor Author

cc @chensun @DharmitD

@hbelmiro hbelmiro marked this pull request as draft June 24, 2024 11:34
@hbelmiro hbelmiro force-pushed the kubeflow-pipeline-upgrade-test branch from ebfb8f4 to ed72396 Compare June 24, 2024 11:37
@hbelmiro hbelmiro marked this pull request as ready for review June 24, 2024 11:56
@google-oss-prow google-oss-prow bot requested a review from gkcalat June 24, 2024 11:56
@rimolive
Copy link
Member

/approve

@rimolive
Copy link
Member

cc @zijianjoy

@hbelmiro
Copy link
Contributor Author

/hold wait for #10946

DharmitD
DharmitD reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 24, 2024
@hbelmiro
Copy link
Contributor Author

cc @chensun @zijianjoy @james-jwu

DharmitD
DharmitD reviewed Jun 26, 2024
View reviewed changes
.github/actions/kfp-cluster/action.yml Outdated

- name: Deploy KFP
shell: bash
run: ./scripts/deploy/github/deploy-kfp.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this script deploys kfp-tekton and not pipelines. Could you update to add kfp deploy steps here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #10946.
This PR must be rebased and merged after #10946.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reverting it to draft.

@hbelmiro hbelmiro marked this pull request as draft June 26, 2024 17:22
@hbelmiro hbelmiro mentioned this pull request Jun 26, 2024
Merged
1 task
@hbelmiro hbelmiro force-pushed the kubeflow-pipeline-upgrade-test branch from ed72396 to 520a868 Compare June 29, 2024 14:18
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 29, 2024
@hbelmiro hbelmiro marked this pull request as ready for review June 29, 2024 14:18
@google-oss-prow google-oss-prow bot requested a review from rimolive June 29, 2024 14:19
@google-oss-prow Google OSS Prow
Copy link

@hbelmiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test 520a868 link false /test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hbelmiro
Copy link
Contributor Author

Rebased. @DharmitD can you take a second look?
/unhold

DharmitD
DharmitD approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/Approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 1, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 568777d into kubeflow:master Jul 1, 2024
4 of 5 checks passed
@hbelmiro hbelmiro deleted the kubeflow-pipeline-upgrade-test branch July 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD approved these changes

@chensun chensun Awaiting requested review from chensun

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@jlyaoyuli jlyaoyuli Awaiting requested review from jlyaoyuli

@gkcalat gkcalat Awaiting requested review from gkcalat

@rimolive rimolive Awaiting requested review from rimolive

Assignees

@DharmitD DharmitD

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move kubeflow-pipeline-upgrade-test to GitHub Actions
3 participants
@hbelmiro @rimolive @DharmitD