Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): return error properly #11424

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Dec 2, 2024

The return statement was missing when id == 0.

Description of your changes:

e26d3ec fix(backend): return error properly

commit e26d3ec
Author: Sébastien Han [email protected]
Date: Mon Dec 2 11:42:49 2024 +0100

fix(backend): return error properly

The `return` statement was missing when `id == 0`.

Signed-off-by: Sébastien Han <[email protected]>

Checklist:

The `return` statement was missing when `id == 0`.

Signed-off-by: Sébastien Han <[email protected]>
Copy link

Hi @leseb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@HumairAK
Copy link
Collaborator

HumairAK commented Dec 2, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 13f83cf into kubeflow:master Dec 2, 2024
19 checks passed
@leseb leseb deleted the fix-small branch December 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants