Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add instructions to develop the API server locally with kind #11459

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Dec 11, 2024

Description of your changes:

This provides instructions to provision a kind cluster with all components deployed except for the API server. The API server can then be run locally through VSCode for debugging and fast development.

Checklist:

Copy link

Hi @mprahl. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl
Copy link
Contributor Author

mprahl commented Dec 11, 2024

It seems the test failures are unrelated to this change.

This provides instructions to provision a kind cluster with all
components deployed except for the API server. The API server can then
be run locally through VSCode for debugging and faster development.

Signed-off-by: mprahl <[email protected]>
@mprahl
Copy link
Contributor Author

mprahl commented Dec 12, 2024

@hbelmiro could you please review the last commit? I saw you had been working with the k8s_version variable and two other workflows needed the variable set.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @mprahl.
/lgtm
/ok-to-test

cc @HumairAK

@mprahl
Copy link
Contributor Author

mprahl commented Dec 12, 2024

@hbelmiro do you have access to cancel and retry the hanging "KFP e2e tests"?

@HumairAK
Copy link
Collaborator

HumairAK commented Dec 12, 2024

awesome stuff @mprahl ! much needed!
I restarted the hanging jobs

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e71825a into kubeflow:master Dec 12, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants