-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add instructions to remote debug the Driver pods #11499
Conversation
/cc @HumairAK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
backend/README.md
Outdated
the Delve port in the pod to your localhost (replace `<driver pod name>` with the actual name). | ||
|
||
```bash | ||
kubectl -n <driver pod name> 2345:2345 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl -n <driver pod name> 2345:2345 | |
kubectl -n kubeflow port-forward pod/<driver pod name> 2345:2345 |
awesome work @mprahl just some small comments above, some are nits, so feel free to update at your discretion for posterity, I tested this in Goland and it worked just fine, I had to use the following command: Goland version: Driver command: Rest of the config can be adapted from "Run the API Server With Debug Configuration" section. For running remote session, use the "Go Remote" configuration And it worked like a charm: |
@HumairAK thanks for the review! Your comments clearly illustrate why my profession isn't writing technical documentation with all those typos lol. |
This makes the driver command configurable so that Delve can be used to execute the driver binary and adds Make targets to build the Driver image for debugging. Signed-off-by: mprahl <[email protected]>
Not at all, I thought it was very well written! Thanks for this! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
self note: always review PRs in an IDE to identify typos 😓
+1 |
Description of your changes:
This makes the driver command configurable so that Delve can be used to execute the driver binary and adds Make targets to build the Driver image for debugging.
Checklist: