Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): add support for uploading new sample pipeline vers #11553

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

HumairAK
Copy link
Collaborator

Resolve: #11541

Description of your changes:
This change adds additional sampleconfig options that provide support for uploading new Pipelines and PipelineVersion samples. To accommodate this and backwards compatibility the structure of the samples config has been changed. Configs following the old format will continue to be supported.

Sample config code is also moved to its own file so as not to bloat main.go

In order to handle conflicts, and detecting pipeline/pipelineVersion existence, additional db queries are made per pipeline and pipeline version at apiserver startup.

Checklist:

backend/src/apiserver/config/config.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
backend/src/apiserver/config/config_test.go Outdated Show resolved Hide resolved
@HumairAK HumairAK force-pushed the issue-11541 branch 3 times, most recently from 2257da7 to 30108ac Compare January 24, 2025 15:37
@HumairAK HumairAK requested a review from hbelmiro January 24, 2025 15:39
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This change adds additional sampleconfig options that provide support
for uploading new Pipelines and PipelineVersion samples. To accommodate
this and backwards compatibility the structure of the samples config has
been changed. Configs following the old format will continue to be
supported.

Sample config code is also moved to its own file so as not to bloat
main.go

In order to handle conflicts, and detecting pipeline/pipelineVersion
existence, additional db queries are made per pipeline and pipeline
version at apiserver startup.

Signed-off-by: Humair Khan <[email protected]>
Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d2ddb2e into kubeflow:master Jan 25, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support pipeline versions in sample pipelines
3 participants