-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync filesystem cache to nas backend when unmount nas #1302
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jdmelo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jdmelo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -289,6 +305,8 @@ func saveVolumeData(opt *Options, mountPath string) error { | |||
} | |||
|
|||
func cleanupMountpoint(mounter mountutils.Interface, mountPath string) (err error) { | |||
klog.Infof("sync filesystem cache to nas backend when umount %s", mountPath) | |||
syscall.Sync() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we need this? Umount should flush dirty cache automatically. Sync() is global, it can be very expansive on a host with tens of volumes and hundreds of GiBs of dirty cache.
…uccessfully
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixed losetup command output, Unmarshal failure issue
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: