Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 🌱 Bump CAPI to v1.9.3 #321

Closed
wants to merge 1 commit into from
Closed

[WIP] 🌱 Bump CAPI to v1.9.3 #321

wants to merge 1 commit into from

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 2, 2024 •
edited
Loading

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.3.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPZ's PR, for comparison: kubernetes-sigs/cluster-api-provider-azure#5316
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2024
@mboersma mboersma changed the title 🌱 Bump CAPI to v1.9.0-rc.0 🌱 [WIP] Bump CAPI to v1.9.0-rc.0 Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2024
@mboersma mboersma changed the title 🌱 [WIP] Bump CAPI to v1.9.0-rc.0 [WIP] 🌱 Bump CAPI to v1.9.0-rc.0 Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from b392d96 to 15dcc5d Compare December 30, 2024 15:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 30, 2024
@mboersma mboersma changed the title [WIP] 🌱 Bump CAPI to v1.9.0-rc.0 [WIP] 🌱 Bump CAPI to v1.9.3 Dec 30, 2024
@mboersma mboersma mentioned this pull request Dec 30, 2024
Closed
@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from 15dcc5d to 662443b Compare December 30, 2024 16:09
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 30, 2024 •
edited
Loading

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-addon-provider-helm-apidiff-main 662443b link false /test pull-cluster-api-addon-provider-helm-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor Author

/close

See #338.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

See #338.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboersma @k8s-ci-robot