Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate azure-sdk-for-go v2 #3409

Closed
33 tasks done
mboersma opened this issue Apr 10, 2023 · 16 comments
Closed
33 tasks done

Integrate azure-sdk-for-go v2 #3409

mboersma opened this issue Apr 10, 2023 · 16 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Milestone

Comments

@mboersma
Copy link
Contributor

mboersma commented Apr 10, 2023

/kind feature

This is an umbrella issue to track the overall progress of converting services not covered by ASO (see #3402) to use Azure's SDK for Go version 2.

Tasks

Preview Give feedback
  1. kind/bug
    willie-yao
  2. willie-yao
  3. priority/important-soon
    mboersma
  4. priority/important-soon
    mboersma
  5. priority/important-soon
    mboersma
  6. priority/important-soon
    mboersma
  7. priority/important-soon
    mboersma
  8. priority/important-soon
    mboersma
  9. priority/important-soon
    mboersma
  10. priority/important-soon
    mboersma
  11. priority/important-soon
    mboersma
  12. priority/important-soon
    mboersma
  13. priority/important-soon
    nojnhuh
  14. priority/important-soon
    nojnhuh
  15. priority/important-soon
    mboersma
  16. priority/important-soon
    mboersma
  17. approved cncf-cla: yes kind/bug lgtm release-note-none size/M
    CecileRobertMichon mboersma
  18. priority/important-soon
    mboersma
  19. priority/important-soon
    mboersma
  20. priority/important-soon
    nojnhuh
  21. priority/important-soon
    mboersma
  22. priority/important-soon
    nojnhuh
  23. priority/important-soon
    nawazkh
  24. priority/important-soon
    mboersma
  25. priority/important-soon
    mboersma
  26. priority/important-soon
    mboersma
  27. priority/important-soon
    nawazkh
  28. priority/important-soon
    mboersma
  29. mboersma
  30. priority/important-soon
    mboersma
  31. approved cncf-cla: yes kind/cleanup lgtm release-note-none size/L
    CecileRobertMichon nojnhuh
  32. priority/important-soon
    mboersma
  33. priority/important-soon
    mboersma

This list comes primarily from Azure/azure-service-operator#2237. This issue replaces #2670.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 10, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Apr 10, 2023

I have a PR that converts NAT gateways and VNET peerings that I'll put out for review today. Edit: see #3410. Edit: VNET peerings is already in ASO, so reworking this.

@mboersma mboersma added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 10, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Apr 14, 2023

See Azure/azure-service-operator#2237 (comment) for discussion. This was based on a stale list and may be moot now.

Edit: updated to reflect current state of ASO service implementation.

@dtzar dtzar added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2023
@mboersma
Copy link
Contributor Author

See https://github.com/Azure/azure-service-operator/labels/capz for the current state of supporting these services in ASO.

@dtzar dtzar added this to the v1.10 milestone May 22, 2023
@jackfrancis jackfrancis modified the milestones: v1.10, next Jun 8, 2023
@mboersma mboersma modified the milestones: next, v1.11 Jul 13, 2023
@dtzar
Copy link
Contributor

dtzar commented Jul 17, 2023

Plan is to fix WI auth issues with #3473 first, then Azure MangedClusters, others are open for contribution right now.

@LochanRn
Copy link
Member

Hi @mboersma @CecileRobertMichon
I don't see a task for migration of the sdk to v2 for managedclusters.
Any reason why ?
My team would like to help as we are looking forward for this feature.

@mboersma
Copy link
Contributor Author

@LochanRn sorry, I finally got around to adding tasks for converting managedcluster and agentpools (although really they're linked). I also opened a WIP PR here: #3857.

Until #3441 is fixed, I don't think any of these tasks can be done in parallel, but we're doing our best to get there and would love any reviews or advice or contributions you might have.

@LochanRn
Copy link
Member

@mboersma Would love to contribute. So is there any task i can pick under this umbrella to help move things faster ?

@CecileRobertMichon
Copy link
Contributor

@LochanRn managedclusters is our top priority for SDK v2 migration, PR is in progress #3794

@mboersma is there a tracking issue we can add in here?

@mboersma
Copy link
Contributor Author

I don't think there's any task here that's ready to work on yet, but hopefully that will change very soon, once one of the outstanding SDKv2 PRs is merged.

@CecileRobertMichon I'll convert the managedclusters item to an issue.

@dtzar
Copy link
Contributor

dtzar commented Aug 22, 2023

@mboersma - which PR are we waiting to merge so LochanRn or others can help out potentially?

@mboersma
Copy link
Contributor Author

@dtzar effectively we're waiting on #3857 to merge since that's when we'll have confidence in the asyncpoller framework and a couple of examples of how to use it.

@mboersma
Copy link
Contributor Author

Now that the asyncpoller framework merged, I think the remaining tasks above could be done by other contributors, using #3882 as a model.

The managedclusters task is moving forward, and I'll promote the others to issues so others can claim them.

@mboersma
Copy link
Contributor Author

The managedclusters/agentpools task finally looks to be about to merge. The remaining three tasks are up for grabs if anyone has bandwidth:

You can use #3882 as a model.

@mboersma
Copy link
Contributor Author

The current plan is: keep converting services to SDKv2 so we're not relying on the now-unsupported SDKv1. Then convert them over to ASO one-by-one.

@nawazkh
Copy link
Member

nawazkh commented Aug 31, 2023

I created #3917 as a marker to update loadbalancer service.

@dtzar
Copy link
Contributor

dtzar commented Sep 18, 2023

Going to close this so it shows as complete for 1.11 milestone release notes and such even though you will finish the one final /test code migration PR shortly after 1.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

No branches or pull requests

7 participants