Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert various references to SDKv2 #3992

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Convert various references to SDKv2 #3992

merged 1 commit into from
Sep 13, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Converts several references to SDKv1 to azure-sdk-for-go version 2.

Which issue(s) this PR fixes:

Refs #3409

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@mboersma mboersma mentioned this pull request Sep 12, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.02% ⚠️

Comparison is base (c6c3fc9) 56.50% compared to head (181b076) 56.48%.
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3992      +/-   ##
==========================================
- Coverage   56.50%   56.48%   -0.02%     
==========================================
  Files         191      191              
  Lines       19498    19490       -8     
==========================================
- Hits        11017    11009       -8     
  Misses       7844     7844              
  Partials      637      637
Files Changed Coverage Δ
azure/scope/machine.go 50.00% <0.00%> (ø)
azure/services/roleassignments/roleassignments.go 63.36% <50.00%> (ø)
azure/converters/subnets.go 100.00% <100.00%> (ø)
azure/services/subnets/subnets.go 78.87% <100.00%> (ø)
azure/services/virtualnetworks/virtualnetworks.go 72.11% <100.00%> (ø)
exp/api/v1beta1/azuremachinepool_webhook.go 75.89% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nojnhuh
nojnhuh reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

azure/services/roleassignments/roleassignments.go
@@ -160,9 +161,9 @@ func (s *Service) getVMSSPrincipalID(ctx context.Context) (*string, error) {
if err != nil {
return nil, errors.Wrap(err, "failed to get principal ID for VMSS")
}
resultVMSS, ok := resultVMSSIface.(compute.VirtualMachineScaleSet)
resultVMSS, ok := resultVMSSIface.(armcompute.VirtualMachineScaleSet)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests failing on main without this change now that scalesets are using SDK v2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They haven't, no, which is...interesting. Let's see if they pass here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e346f4144db7ce3949ae7181128ac006ce705b9

@mboersma
Copy link
Contributor Author

/retest

CecileRobertMichon
CecileRobertMichon reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit a0ecaf7 into kubernetes-sigs:main Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @nojnhuh