BUG: IBM Cloud Infra: Return existing VPC ID (#2141)

Fix bug where an existing VPC ID that was found, was not
being returned, resulting in attempts to recreate the
VPC.

Related: #2140

cloud/scope/vpc_cluster.go

@@ -496,12 +496,13 @@ func (s *VPCClusterScope) GetVPCID() (*string, error) {
 
 			// Check if the VPC was found and has an ID
 			if vpcDetails != nil && vpcDetails.ID != nil {
-				// Set VPC ID in Status to shortcut future lookups
+				// Set VPC ID in Status to shortcut future lookups, prior to returning the ID.
 				s.SetResourceStatus(infrav1beta2.ResourceTypeVPC, &infrav1beta2.ResourceStatus{
 					ID:    *vpcDetails.ID,
 					Name:  s.NetworkSpec().VPC.Name,
 					Ready: true,
 				})
+				return vpcDetails.ID, nil
 			}
 		}
 	}