Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add templates for cluster-api version update and release tracker #2124

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add templates for cluster-api version update and release tracker #2124

merged 1 commit into from
Jan 10, 2025
+67 −0

Conversation

Amulyam24
Copy link
Contributor

What this PR does / why we need it:
Add templates for cluster-api version update and release tracker

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add templates for cluster-api version update and release tracker

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 88b0ccb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6780be192caa930008b88433
😎 Deploy Preview https://deploy-preview-2124--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amulyam24 Amulyam24 force-pushed the add-templates branch 2 times, most recently from 7e66564 to 13bd989 Compare January 9, 2025 08:07
@Amulyam24
Copy link
Contributor Author

@mkumatag @Prajyot-Parab, PTAL and let me know if I missed anything.

Prajyot-Parab
Prajyot-Parab reviewed Jan 9, 2025
View reviewed changes
.github/ISSUE_TEMPLATE/release.md Outdated
**Tasks:**

After every CAPIBM major version release:
- [ ] [Update version in metadata.yaml](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/metadata.yaml) and [e2e test config files](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/tree/main/test/e2e/config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amulyam24 what do we update exactly in e2e test config files post our release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We update the infrastructure provider version. Added the change, PTAL.

@Prajyot-Parab
Copy link
Contributor

@Amulyam24 do you think we should add relevant older PR references specific to tasks just a record of what exactly needs to be done? similar to prior art refs in CAPI issues.

@mkumatag
Copy link
Member

mkumatag commented Jan 9, 2025

@mkumatag @Prajyot-Parab, PTAL and let me know if I missed anything.

lgtm

Prajyot-Parab
Prajyot-Parab approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit a6f8452 into kubernetes-sigs:main Jan 10, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amulyam24 @Prajyot-Parab @mkumatag @k8s-ci-robot