-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owners: add tomasaschan to reviewers #381
owners: add tomasaschan to reviewers #381
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for input from tomasaschan @tomasaschan would like to be a reviewer? (With a view to getting ownership in time, but we're not supposed to start you as an owner) I think you have demonstrated a deep understanding of the code and an ability to contribute. cc @atoato88 and @johnsonj - do you agree with this suggestion? |
I'd be happy to! |
/lgtm Just to formally indicate this (even though it won't work until this is merged, IIUC). |
@tomasaschan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@johnsonj: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Well that's not good, either prow is having a moment or maybe we've change the config (so that approvers can't LGTM?)... I'll try to figure out what's going on here |
/lgtm |
@tomasaschan is not member of org member? |
I can become your sponsor! |
Thank you for mentioning me, I commented on kubernetes/org#4837 |
Thank you! Then I think we just need a +1 from Justin there too, which I suppose will have to wait until I after kubecon :) |
I've now been added as a member of the org, so this should be unblocked! /hold cancel (probably won't work) |
/verify-owners |
Thank you for catching up this PR and I'm very appreciate that you joined this repo! 😄 |
This was discussed already in kubernetes-sigs#381 but hasn't happened yet.
This was discussed already in kubernetes-sigs#381 but hasn't happened yet.
No description provided.