Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite preemption loop in hierarchal cohorts #4030

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Infinite preemption loop in hierarchal cohorts #4030

wants to merge 1 commit into from
+129 −0

Conversation

vladikkuzn
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3779

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 42a40b5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/678f6e4b09ed800008a6e0a4
😎 Deploy Preview https://deploy-preview-4030--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vladikkuzn
Copy link
Contributor Author

/assign

gabesaba
gabesaba reviewed Jan 23, 2025
View reviewed changes
test/integration/controller/admissionchecks/provisioning/provisioning_test.go
clusterQueueA := testing.MakeClusterQueue("guaranteed-tenant-a").
Cohort(cohortName).
ResourceGroup(*testing.MakeFlavorQuotas("default").
Resource("cpu", "150m", "150m").Obj()).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

150m, and unset the borrowing limit (2nd parameter)

test/integration/controller/admissionchecks/provisioning/provisioning_test.go
clusterQueueBestEffort := testing.MakeClusterQueue("best-effort").
Cohort(cohortName).
ResourceGroup(*testing.MakeFlavorQuotas("default").
Resource("cpu", "0m", "0m").Obj()).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unset borrowing limit

test/integration/controller/admissionchecks/provisioning/provisioning_test.go
// Step 1: Create ClusterQueues and Cohort
cohortName := "testing"

clusterQueueA := testing.MakeClusterQueue("guaranteed-tenant-a").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is clusterQueue2? GuaranteedTenantB with 150m nominal

test/integration/controller/admissionchecks/provisioning/provisioning_test.go
)

ginkgo.JustBeforeEach(func() {
fwk.StartManager(ctx, cfg, managerSetup())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair sharing needs to be enabled

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabesaba gabesaba gabesaba left review comments

@PBundyra PBundyra Awaiting requested review from PBundyra

Assignees

@vladikkuzn vladikkuzn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite preemption loop in hierarchal cohorts
3 participants
@vladikkuzn @k8s-ci-robot @gabesaba