Adding cypress image #1427
Adding cypress image #1427
Conversation
metalice
force-pushed
the
adding-cypress-image
branch
4 times, most recently
from
2d1d392 to
8d8fbf0
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 36.81% 36.20% -0.62%
==========================================
Files 158 159 +1
Lines 2548 2580 +32
Branches 599 590 -9
==========================================
- Hits 938 934 -4
- Misses 1428 1644 +216
+ Partials 182 2 -180 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I run it on my env. and it looks ok.
Few comments:
- Can you please separate/divide this changes to cypress support and macOS support? It will help tracking changes in the future.
- UX dev asked for macOS support as well and posted a PR Add --arch when running podman to allow running on ARM machines #1380 already so I wonder why it's not working for you and is working for them now.
- two more small comments below
ci/start-console.sh
Outdated
| @@ -7,9 +7,19 @@ source ${script_dir}/configure/openshift.sh | |||
| CONSOLE_CONTAINER_NAME=okd-console | |||
| FORKLIFT_NAMESPACE=konveyor-forklift | |||
|
|
|||
| PLUGIN_NAME="forklift-console-plugin" | |||
| PLUGIN_URL=${PLUGIN_URL:-"http://localhost:9001"} | |||
| BASE_HOST_URL=${BASE_HOST_URL:-"http://localhost"} | |||
There was a problem hiding this comment.
Shouldn't it be https and not always http?
| BASE_HOST_URL=${BASE_HOST_URL:-"http://localhost"} | |
| BASE_HOST_URL=${BASE_HOST_URL:-"https://localhost"} |
There was a problem hiding this comment.
the base host used before my changes is http
| @@ -19,7 +19,7 @@ | |||
| "clean:all": "yarn clean ./node_modules ./.rollup.cache", | |||
| "i18n": "i18next \"./src/**/*.{js,jsx,ts,tsx}\" [-oc] -c ./i18next-parser.config.js", | |||
| "build": "NODE_ENV=production webpack", | |||
| "start": "NODE_ENV=development webpack serve", | |||
| "start": "NODE_ENV=development webpack serve --progress", | |||
There was a problem hiding this comment.
Can we omit the --progress flag before merging?
It makes the webpack output longer which is .annoying...
There was a problem hiding this comment.
yes, of course, I can omit it. I've added it :) It's just to know the percentage progress when u sit and wait to 100% to start working. with all other projects we do have it with progress
There was a problem hiding this comment.
And isn't it extending the build running time? It seems like it is for me :)
https://webpack.js.org/guides/build-performance/#progress-plugin
|
| INVENTORY_SERVER_HOST=${INVENTORY_SERVER_HOST:-"$BASE_HOST_URL:30444"} | ||
| SERVICES_API_SERVER_HOST=${SERVICES_API_SERVER_HOST:-"$BASE_HOST_URL:30446"} |
There was a problem hiding this comment.
Here the urls were set by default before the fix to https://localhost and not to http://localhost, so you may need two variables or just set the HOST part..
There was a problem hiding this comment.
changed to https thanks!
There was a problem hiding this comment.
This is not working now, since the console doesn't find the plugin. It is searching for the plugin on https://localhost and the plugin is running using http://localhost.
The original line was:
You need to use different schema for each:
for PLUGIN_URL - http
for BASE_HOST_URL - https
Signed-off-by: Matan Schatzman <[email protected]>
metalice
force-pushed
the
adding-cypress-image
branch
from
8d8fbf0 to
c363d22
Compare
|
|
/hold |
sgratch
added
the
do-not-merge/work-in-progress
Adding cypress image and expanding start script to support mac