Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bazel #1301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove bazel #1301

wants to merge 1 commit into from

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Jan 13, 2025

  • Remove all .bazel files
  • Remove .bazelrc
  • Add forklift-operator-index dockerfile to build the opm catalog index.
  • Fix operator containerfile which was missing the ansible-galaxy requirements
  • Add ovirt-populator dockerfile for upstream
  • Reflet the makefile changes in the README

Makefile changes:

  • Replace the bazel builds with the container builds
  • Add deploy-operator-index target to deploy the new index image
  • Start to dynamically adapt the bundle images depending on the images which were build before.
  • For example you can run
export REGISTRY_ORG=user
make push-controller-image \
     push-operator-bundle-image \
     push-operator-index-image \
     deploy-operator-index
  • This will build the controller image and push it to your user in quay.
    Next it will build the bundle image which points controller to the newly built image and the other images will be pointing to the "default" images from kubev2v org. This way we don't need to rebuild all images if we want to test the changes only in one image.

Depends on: kubev2v/forkliftci#136
Which depends on these changes so we need to merge one of them first even with a failing pipeline. I did a test pointing to the test branch and it passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.45%. Comparing base (3113e86) to head (7cbd0f2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   15.50%   15.45%   -0.05%     
==========================================
  Files         112      112              
  Lines       23377    23377              
==========================================
- Hits         3624     3613      -11     
- Misses      19466    19479      +13     
+ Partials      287      285       -2     
Flag Coverage Δ
unittests 15.45% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas force-pushed the remove_bazel branch 6 times, most recently from 6a35388 to 64c9fb0 Compare January 14, 2025 08:27
@yaacov yaacov mentioned this pull request Jan 16, 2025
3 tasks
@mnecas mnecas force-pushed the remove_bazel branch 12 times, most recently from d5273cb to 7156add Compare January 17, 2025 10:01
@mnecas
Copy link
Member Author

mnecas commented Jan 17, 2025

As a test I have updated the github action to use my branch from the forkliftci as this patch is depending on it. kubev2v/forkliftci#136

With those changes the action passed
image

@mnecas mnecas changed the title Remove bazel WIP Remove bazel Jan 17, 2025
@mnecas mnecas force-pushed the remove_bazel branch 4 times, most recently from 77c0e3f to 802ca03 Compare January 17, 2025 13:48
Signed-off-by: Martin Necas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants