Fix OVA generation #102
Merged
Fix OVA generation #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
machacekondra
commented
Dec 12, 2024
machacekondra
commented
- Flush after last header
- rename the VM to MigrationAssessment
- Send Content-Type and Content-length headers
machacekondra
force-pushed
the
ova_gen
branch
from
3859d01 to
10a650a
Compare
tupyy
reviewed
Dec 16, 2024
internal/image/ova.go
Outdated
| size := blockSize | ||
|
|
||
| // Size of the file content, rounded up to nearest 512 bytes | ||
| size += (contentSize + blockSize - 1) / blockSize * blockSize |
There was a problem hiding this comment.
Isn't / blockSize * blockSize = 1
There was a problem hiding this comment.
Not sure I understand. It could be =1. But only in case contentSize + blockSize - 1 = 262144.
There was a problem hiding this comment.
Oh, I know hat you mean. I should do:
((contentSize + blockSize - 1) / blockSize) * blockSize
to make it clear
- Flush after last header - rename the VM to MigrationAssessment - Send Content-Type and Content-length headers Signed-off-by: Ondra Machacek <[email protected]>
machacekondra
force-pushed
the
ova_gen
branch
from
10a650a to
a396711
Compare
tupyy
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.