Improve the end-to-end tests and fix the issue with 'BeforeEach' code block #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ jobs: | |||
|
|
|||
| - name: Deploy vcsim | |||
| run: | | |||
| kubectl create deployment vcsim --image=docker.io/vmware/vcsim | |||
| make deploy-vsphere-simulator | |||
There was a problem hiding this comment.
This is cool! With this we can deploy multiple vcsims and test multiple environemnts :)
There was a problem hiding this comment.
Thank's. Yes, it's much more convenient and also provides the flexibility to override the arguments passed to the container's ENTRYPOINT, allowing the simulator to be loaded with customizations.
AvielSegev
force-pushed
the
improve-e2e-test
branch
from
b8080e9 to
c37cdf2
Compare
…ch causes errors when running more than one test. Signed-off-by: Aviel Segev <[email protected]>
AvielSegev
force-pushed
the
improve-e2e-test
branch
from
c37cdf2 to
21148e1
Compare
| @@ -132,7 +132,7 @@ func testVmwareConnection(requestCtx context.Context, credentials *config.Creden | |||
| err = client.Login(ctx, u.User) | |||
| if err != nil { | |||
| err = liberr.Wrap(err) | |||
| if strings.Contains(err.Error(), "incorrect") && strings.Contains(err.Error(), "password") { | |||
| if strings.Contains(err.Error(), "Login failure") { | |||
There was a problem hiding this comment.
Can you double check this works also in real env?
machacekondra
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR introduces four additional test cases as part of the end-to-end (e2e) tests to validate login behavior under the following scenarios:
To ensure these tests pass, this PR also addresses the following issues:
BeforeEach and AfterEach Conflict:
Previously, the afterEach block did not remove agent records from the database, even though the associated VM was deleted. This caused failures in the beforeEach block due to unexpected matches between newly created agents and old database records. This has now been fixed.
Error Handling in testVmwareConnection:
When an error occurred in the testVmwareConnection method, the expected behavior was to return:
Unauthorized (401) for invalid credentials
BadRequest (400) for other errors
However, this logic was broken due to a if statement that checked wrong substring compare to what returned by the vCenter client. The issue has been resolved.
Additionally, the Vcsim (vSphere simulator) used in the e2e tests is now configured with a core username and password (123456) instead of allowing any non-empty credentials by default.