Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project-infra, botreview: Initial implementation of prow plugin to automate simple reviews #2448

Merged
merged 17 commits into from
Dec 7, 2023
Merged

project-infra, botreview: Initial implementation of prow plugin to automate simple reviews #2448

merged 17 commits into from
Dec 7, 2023

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 10, 2022 •
edited
Loading

botreview aims to automate reviews that follow simple patterns.

Tracked in #3100

This first implementation can be used as a cli tool, but also has the setup for the deployment to KubeVirt prow. Tested with prow-deploy test setup and phony GitHub events.

Note that the deployment currently has --dry-run=true enabled, since we want to test it's stability gradually.

Implemented review strategies

Review strategies implemented today:

It can also handle mixed PRs, where each change abides by the rules of the strategy.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 10, 2022
@rmohr
Copy link
Member

rmohr commented Nov 10, 2022

Nice!

@dhiller dhiller mentioned this pull request Nov 28, 2022
Merged
@dhiller dhiller changed the title WIP: botreview - tool to automate simple reviews WIP: botreview - automate simple reviews Nov 28, 2022
This was referenced Dec 9, 2022
Merged
Merged
Merged
This was referenced Jan 2, 2023
Merged
Merged
@dhiller dhiller mentioned this pull request Jan 12, 2023
Merged
@dhiller dhiller mentioned this pull request Jan 23, 2023
Merged
@dhiller dhiller mentioned this pull request Feb 7, 2023
Merged
@dhiller dhiller mentioned this pull request Mar 14, 2023
Merged
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Apr 21, 2023

/remove-lifecycle stale
/lifecycle frozen

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2023
@kubevirt-bot
Copy link
Contributor

@dhiller: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/remove-lifecycle stale
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2023
@dhiller dhiller mentioned this pull request Jun 15, 2023
Merged
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@dhiller dhiller mentioned this pull request Jun 23, 2023
Merged
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2023
dhiller added 17 commits December 7, 2023 12:23
@dhiller
new, external_plugin: create botreview external prow plugin
6f96d3c 
Create external prow plugin. Implement first review strategy "prow image bump".

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
new, review strategy: bump_kubevirtci
d955435 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
new, cli: robots/cmd/botreview
0ade615 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
new, review strategy: prow_autobump
39092d5 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix, image_update: exclude release branch configs
3facf53 
Also use base and head for calculating the diff from a PR

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix, prow_autobump: utility images
12f3a35 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
help, external_plugin: botreview plug in comment
306f495 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix: handle mixed review types
8e74a03 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix, test: bazel setup, unit test
bc9dc3a 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix: handle comment length
98be0e8 
Use file names only for comment if otherwise too long

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
bazel, image, docs: botreview image
8ca1dd5 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
fix, image_update: add missing review failure
ab5fffe 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
image: add Containerfile for botreview
c48c19a 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
prow, deployment: create deployment, add to external_plugins config
b747100 
Fix copyright notice, pass through dry run and add checkout in server mode.
Add server checkout. Don't attach comment if the review didn't match any type.
Use latest tag for botreview image. Fix bazel with gazelle.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
review: address comments
f3105a9 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
make, push: fix path to Containerfile
811d631 
Signed-off-by: Daniel Hiller <[email protected]>
@dhiller
Use botreview-oauth-token
c61e7cf 
Signed-off-by: Daniel Hiller <[email protected]>
brianmcarey
brianmcarey approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

This will be great to automate some of the PR reviews that are generated with automation. Thanks @dhiller !!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@kubevirt-bot kubevirt-bot merged commit 8b4e797 into kubevirt:main Dec 7, 2023
11 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the following 2 configmaps:

  • plugins configmap in namespace kubevirt-prow at cluster default using the following files:
    • key plugins.yaml using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml
  • job-config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key project-infra-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-postsubmits.yaml

In response to this:

botreview aims to automate reviews that follow simple patterns.

Tracked in #3100

This first implementation can be used as a cli tool, but also has the setup for the deployment to KubeVirt prow. Tested with prow-deploy test setup and phony GitHub events.

Note that the deployment currently has --dry-run=true enabled, since we want to test it's stability gradually.

Implemented review strategies

Review strategies implemented today:

It can also handle mixed PRs, where each change abides by the rules of the strategy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhiller @kubevirt-bot @rmohr @brianmcarey