Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update remaining jobs to use podman #2534

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Update remaining jobs to use podman #2534

merged 1 commit into from
Jan 4, 2023

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Jan 4, 2023 •
edited
Loading

There were some jobs that use images that are built from the bootstrap
image. These images were rebuilt recently and the jobs were updated[1] so these jobs now require the
podman preset to be enabled.

[1] #2531

Signed-off-by: Brian Carey [email protected]

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 4, 2023
@brianmcarey
Copy link
Member Author

/rehearse

@brianmcarey brianmcarey mentioned this pull request Jan 4, 2023
Merged
@brianmcarey
Copy link
Member Author

brianmcarey commented Jan 4, 2023 •
edited
Loading

Rehearsals passed
rehearsal-pull-kubevirtci-bump-kubevirt
rehearsal-pull-project-infra-prow-deploy-test

HCO jobs will be handled by #2532

@brianmcarey
Update remaining jobs to use podman
4cd2d40 
There were some jobs that use images that are built from the bootstrap
image. These images were rebuilt recently and the jobs were updated[1] so these jobs now require the
podman preset to be enabled.

[1] kubevirt#2531

Signed-off-by: Brian Carey <[email protected]>
@brianmcarey brianmcarey marked this pull request as ready for review January 4, 2023 12:44
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2023
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 4, 2023 •
edited
Loading

@brianmcarey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-ansible-kubevirt-modules-e2e-os-3.11.0 a4a577d link unknown /test pull-ansible-kubevirt-modules-e2e-os-3.11.0
rehearsal-pull-hyperconverged-cluster-operator-e2e-k8s-1.23 a4a577d link unknown /test pull-hyperconverged-cluster-operator-e2e-k8s-1.23
rehearsal-pull-hyperconverged-cluster-operator-e2e-k8s-1.24 a4a577d link unknown /test pull-hyperconverged-cluster-operator-e2e-k8s-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brianmcarey
Copy link
Member Author

/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller January 4, 2023 12:45
dhiller
dhiller approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@dhiller
Copy link
Contributor

dhiller commented Jan 4, 2023

/override pull-project-infra-prow-deploy-test

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test

In response to this:

/override pull-project-infra-prow-deploy-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit d6824d7 into kubevirt:main Jan 4, 2023
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key ansible-kubevirt-modules-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/ansible-kubevirt-modules/ansible-kubevirt-modules-presubmits.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml
  • key kubevirtci-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
  • key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

In response to this:

There were some jobs that use images that are built from the bootstrap
image. These images were rebuilt recently and the jobs were updated[1] so these jobs now require the
podman preset to be enabled.

[1] #2531

Signed-off-by: Brian Carey [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller approved these changes

@acardace acardace Awaiting requested review from acardace

@aglitke aglitke Awaiting requested review from aglitke

@davidvossel davidvossel Awaiting requested review from davidvossel

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

@vatsalparekh vatsalparekh Awaiting requested review from vatsalparekh

@enp0s3 enp0s3 Awaiting requested review from enp0s3

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@machacekondra machacekondra Awaiting requested review from machacekondra

Assignees

@dhiller dhiller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianmcarey @kubevirt-bot @dhiller