chore: SingleComboBoxの内部ロジックを整理する #5337
Draft
+214
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-add-use-decorators
AtsushiM
commented
Jan 27, 2025
| @@ -59,42 +59,37 @@ const ListBoxItemButton = <T,>({ | |||
| const buttonStyle = useMemo( | |||
| () => | |||
| button({ | |||
| active: !!isActive, | |||
| active: isActive, | |||
There was a problem hiding this comment.
isActiveは常にbooleanなので !!でboolean化する必要はありません
AtsushiM
commented
Jan 27, 2025
| {label} | ||
| </button> | ||
| ) | ||
| } | ||
|
|
||
| const MemoizedNewIconWithText = React.memo<{ label: ReactNode }>(({ label }) => ( | ||
| <FaPlusCircleIcon color="TEXT_LINK" text={<Text color="TEXT_LINK">「{label}」を追加</Text>} /> |
There was a problem hiding this comment.
Icon自体はmemo化されていますが、textにReact.Componentが渡されれば毎回再レンダリングされてしまいます。
幸いlabelが切り替わる可能性がないため、Icon毎Textを含めた状態でmemo化するようにしました
yagimushi
force-pushed
the
chore-refactoring-SingleComboBox
branch
2 times, most recently
from
833cfa2 to
15701b3
Compare
commit: |
yagimushi
force-pushed
the
chore-refactoring-SingleComboBox
branch
from
15701b3 to
549eec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法