Print string for comparison operands only once when it is same for both #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both operands of a failed comparison get the very same string representation from `FormatForComparisonFailureMessage`, it is not necessary to print it twice. For example:
auto x = std::numeric_limits<int64_t>::lowest();
auto y = std::numeric_limits<int64_t>::min();
ASSERT_NE(x, y);
Output before this commit:
> Expected: (x) != (y), actual: -9223372036854775808 vs -9223372036854775808
Output after this commit:
> Expected: (x) != (y), actual: -9223372036854775808 (same for both operands)
kuzkry
force-pushed
the
Do-not-print-same-string-twice
branch
from
c3b3153 to
eeca213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2.
When both operands of a failed comparison get the very same string representation from FormatForComparisonFailureMessage, it is not necessary to print it twice. For example:
Output before this commit:
Output after this commit: