Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable changing HA zones setting #1671

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Disable changing HA zones setting #1671

merged 1 commit into from
Jan 23, 2025

Conversation

KsaweryZietara
Copy link
Contributor

Description

The ability to enable or disable HA zone settings should not be available. However, it is currently possible to enable HA zones.

Changes proposed in this pull request:

  • change HA zones validation function,
  • adjust tests to changed scenario,
  • update schema description.

Related issue(s)
See also #952

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jan 23, 2025
@KsaweryZietara KsaweryZietara self-assigned this Jan 23, 2025
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner January 23, 2025 14:36
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 23, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 23, 2025 14:36
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@KsaweryZietara KsaweryZietara mentioned this pull request Jan 23, 2025
Open
10 tasks
@kyma-gopher-bot kyma-gopher-bot merged commit 60a8b0d into kyma-project:main Jan 23, 2025
32 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KsaweryZietara @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot