feat: add assertion compiler #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddycharly
force-pushed
the
assertion-compiler
branch
from
741b0de to
2573ada
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 23.79% 23.74% -0.05%
==========================================
Files 90 91 +1
Lines 4202 4236 +34
==========================================
+ Hits 1000 1006 +6
- Misses 3105 3133 +28
Partials 97 97 ☔ View full report in Codecov by Sentry. |
eddycharly
force-pushed
the
assertion-compiler
branch
from
2573ada to
1eb0602
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
assertion-compiler
branch
from
1eb0602 to
51461a4
Compare
Comment on lines
+17
to
+20
| func hashStringXXHASH(s string) uint32 { | ||
| sum := xxhash.Sum64String(s) | ||
| return uint32(sum) //nolint:gosec | ||
| } |
There was a problem hiding this comment.
The cache library uses github.com/cespare/xxhash/v2 for hashing: https://github.com/elastic/go-freelru/blob/a8ff11dc7ea0d398a6b9aefe62aeff605f2d8962/bench/hash.go#L191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add assertion compiler (with caching).