clean up #3
Closed
clean up #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the tests to run in parallel. Co-authored-by: Zitrone <[email protected]>
Co-authored-by: Zitrone <[email protected]>
Allows users to refer to `config.programs.ydotool.group` rather than hard-coding "ydotool". Allows users to override the group name for whatever reason. closes NixOS#317013. Co-authored-by: Cosima Neidahl <[email protected]> Co-authored-by: Zitrone <[email protected]>
quantenzitrone
force-pushed
the
ydotool-group
branch
from
5b2b8ac to
12f3389
Compare
Excellent.
Makes sense, thanks!
I've left that where it was, since it's only applicable to that part of the code.
Cheers! I've pushed an updated version applying some of these changes; what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in the commits:
test split up:
runtime directory deduplication:
let ... inmaking group configurable:
my clean-up is probably pretty opinionated, you can change stuff back, but please format with nixfmt-rfc-style afterwards